Add GetPooledArraySpan(...) extension method #10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new `GetPooledArraySpan(...)` extension method that returns a pooled array as a `Span<T>` with the expected length. This can help avoid bugs that can occur if a pooled array's `Length` is accidental used.
ryzngard
reviewed
Jul 16, 2024
src/Shared/Microsoft.AspNetCore.Razor.Utilities.Shared/PooledObjects/PooledArray`1.cs
Show resolved
Hide resolved
ryzngard
approved these changes
Jul 16, 2024
davidwengier
approved these changes
Jul 16, 2024
ryzngard
approved these changes
Jul 16, 2024
jjonescz
approved these changes
Jul 16, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new
GetPooledArraySpan(...)extension method that returns a pooled array as aSpan<T>with the expected length. This can help avoid bugs that can occur if a pooled array'sLengthis accidental used.