Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handful of unit test issues and the intermittent IndexOutOfRangeException failures #10635

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Fix handful of unit test issues and the intermittent IndexOutOfRangeException failures #10635

merged 7 commits into from
Jul 17, 2024

Commits on Jul 16, 2024

  1. Add missing ReturnAsync for mock

    @DustinCampbell
    DustinCampbell committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e67fab8 View commit details
    Browse the repository at this point in the history

  2. Move CreateTextLoader helper to TestMocks class

    @DustinCampbell
    DustinCampbell committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2edc201 View commit details
    Browse the repository at this point in the history

  3. Fix BackgroundDocumentGeneratorTest that was throwing exception 

    The ProcessWorkAndRestart test was throwing an exception and swallowing it because a document was added to a project when the document's file path was outside of the project's.
    @DustinCampbell
    DustinCampbell committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d96c004 View commit details
    Browse the repository at this point in the history

  4. Do not swallow test logging errors that occur outside of tests

    @DustinCampbell
    DustinCampbell committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3138fb0 View commit details
    Browse the repository at this point in the history

  5. Ensure that we log exceptions during tests

    @DustinCampbell
    DustinCampbell committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    214d921 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Don't read past end of span in NormalizeAndDedupeSlashes

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    59aa56d View commit details
    Browse the repository at this point in the history

  2. Add "/" as special case when normalizing directories

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6d76c6d View commit details
    Browse the repository at this point in the history