Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Razor logging #10641

Merged
merged 16 commits into from
Jul 19, 2024
Merged

Revisit Razor logging #10641

merged 16 commits into from
Jul 19, 2024

Commits on Jul 17, 2024

  1. Add StringExtensions.CreateString(...) helper

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    32fed2e View commit details
    Browse the repository at this point in the history

  2. Use CreateString helper in CodeWriter

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6f3fcc1 View commit details
    Browse the repository at this point in the history

  3. Use ArgHelper in CodeWriter

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8d9b438 View commit details
    Browse the repository at this point in the history

  4. Add MemoryBuilder<T> helper

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    aed8cfa View commit details
    Browse the repository at this point in the history

  5. Extract log message formatting and reduce string allocations

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f6bdc0b View commit details
    Browse the repository at this point in the history

  6. Use LogMessageFormatter in a couple existing loggers

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5e63634 View commit details
    Browse the repository at this point in the history

  7. Use same EmptyLoggerFactory throughout Razor

    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cdae4fa View commit details
    Browse the repository at this point in the history

  8. Use different ILoggerProvider for integration tests and clean up 

    While adding a new ILoggerProvider for integration tests that ignores messages sent after the output is invalid, I noticed a bunch of things to clean up. Importantly, Razor's ILoggerProvider no longer implements IDisposable as the MS.Extensions.Logging version does.
    @DustinCampbell
    DustinCampbell committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c945faf View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Apply code review feedback for MemoryBuilder<T>

    @DustinCampbell
    DustinCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    54f3d27 View commit details
    Browse the repository at this point in the history

  2. Add comment back to CodeWriter.GenerateString(...)

    @DustinCampbell
    DustinCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    590205b View commit details
    Browse the repository at this point in the history

  3. Use static lambda

    @DustinCampbell
    DustinCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4002d45 View commit details
    Browse the repository at this point in the history

  4. Assert that nextCapacity > _memory.Length in MemoryBuilder<T>

    @DustinCampbell
    DustinCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6fa6e78 View commit details
    Browse the repository at this point in the history

  5. Use static readonly field

    @DustinCampbell
    DustinCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bdb1348 View commit details
    Browse the repository at this point in the history

  6. Use ThrowHelper within ArgHelper

    @DustinCampbell
    DustinCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3b480de View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Add XML doc comments for StreamExtensions.CreateString and SpanAction

    @DustinCampbell
    DustinCampbell committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    749ded8 View commit details
    Browse the repository at this point in the history

  2. Clean up MemoryBuilder<T>.Grow when checking again ArrayMaxLength

    @DustinCampbell
    DustinCampbell committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fabbeeb View commit details
    Browse the repository at this point in the history