Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global namespace component bind #10798

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

chsienki
Copy link
Contributor

Previously when creating the TagHelperDescriptors for a component in the global namespace we skipped adding the tag matcher rule for the short name match as it would be the same as the fully qualified one.

However, various downstream things expect components to have exactly one tag matching rule. Given that without the rule, we can never actually match this tag helper anyway; instead, just don't create the descriptor at all.

Fixes: #10609

@chsienki chsienki added the area-compiler Umbrella for all compiler issues label Aug 27, 2024
@chsienki chsienki requested a review from a team as a code owner August 27, 2024 18:55
@chsienki
Copy link
Contributor Author

@dotnet/razor-compiler for review please :)

…ionTests/ComponentCodeGenerationTestBase.cs

Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component in the global namespace causes exception when using @bind syntax
4 participants