Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohost Spell Check #10825

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Cohost Spell Check #10825

merged 9 commits into from
Sep 6, 2024

Conversation

davidwengier
Copy link
Contributor

Needs dotnet/roslyn#74978
Fixes #10746
Part of #9519

@davidwengier davidwengier requested a review from a team as a code owner September 3, 2024 06:25
@davidwengier davidwengier mentioned this pull request Sep 3, 2024
Open
maryamariyan
maryamariyan approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (CI is failing due to a missing assembly reference in RemoteCSharpSpellCheckService,cs

@davidwengier
Copy link
Contributor Author

To be in line with semantic tokens, which works in a very similar style to this, I think I'll rename ICSharpSpellCheckService to ICSharpSpellCheckRangeProvider. Better indication of what it does and how it fits in.

@DustinCampbell
Copy link
Member

LGTM. (CI is failing due to a missing assembly reference in RemoteCSharpSpellCheckService,cs

CI is failing because this requires a Roslyn update (the one @davidwengier mentioned in his PR description above).

DustinCampbell
DustinCampbell reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change generally looks good! I noted a few questions/comments.

...Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/SpellCheck/DocumentSpellCheckEndpoint.cs Outdated Show resolved Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/SpellCheck/SpellCheckService.cs Outdated Show resolved Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/SpellCheck/SpellCheckService.cs Outdated Show resolved Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/SpellCheck/SpellCheckService.cs Outdated Show resolved Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/SpellCheck/SpellCheckService.cs Show resolved Hide resolved
...or/src/Microsoft.CodeAnalysis.Remote.Razor/SpellCheck/RemoteCSharpSpellCheckRangeProvider.cs Outdated Show resolved Hide resolved
...or/src/Microsoft.CodeAnalysis.Remote.Razor/SpellCheck/RemoteCSharpSpellCheckRangeProvider.cs Outdated Show resolved Hide resolved
...isualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostDocumentSpellCheckEndpoint.cs Outdated Show resolved Hide resolved
...sualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostWorkspaceSpellCheckEndpoint.cs Outdated Show resolved Hide resolved
...src/Microsoft.AspNetCore.Razor.LanguageServer/SpellCheck/LspCSharpSpellCheckRangeProvider.cs Show resolved Hide resolved
alexgav
alexgav approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier requested a review from a team as a code owner September 6, 2024 01:51
@davidwengier
Merge remote-tracking branch 'upstream/main' into CohostSpellCheck
a3ee54d 
# Conflicts:
#	eng/targets/Services.props
#	src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Remote/RazorServices.cs
@davidwengier davidwengier merged commit 07e1382 into dotnet:main Sep 6, 2024
12 checks passed
@davidwengier davidwengier deleted the CohostSpellCheck branch September 6, 2024 06:05
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 6, 2024
This was referenced Sep 10, 2024
Closed
Closed
Closed
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.12 P3 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryamariyan maryamariyan maryamariyan approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@alexgav alexgav alexgav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.12 P3
Development

Successfully merging this pull request may close these issues.

Port SpellCheck endpoint to cohosting
5 participants
@davidwengier @DustinCampbell @alexgav @maryamariyan @phil-allen-msft