Remove some things from IProjectSnapshot for cohostings benefit
#10831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was only used in one place, and that place could never have any result except false due to a FileKind check above
This is only called from the LSP server, and shouldn't be called from cohosting, so now it can't be!
davidwengier
commented
Sep 4, 2024
| @@ -27,12 +27,6 @@ internal static class IDocumentSnapshotExtensions | |||
|
|
|||
| var project = documentSnapshot.Project; | |||
|
|
|||
| // If the document is an import document, then it can't be a component | |||
| if (project.IsImportDocument(documentSnapshot)) | |||
There was a problem hiding this comment.
This is mentioned in the commit message, but if you're looking at the PR as a whole let me explain here: This was the only call to IsImportDocument, and it was impossible for it to ever return true because 10 lines above this there is a check for FileKind. Import documents have their own file kind, so would never get this far.
DustinCampbell
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Thank you for taking a shot at this! These methods have been on my list to remove from IProjectSnapshot for a long while. However, I'm uncomfortable with the changes to ProjectChangeEventsArgs, and ProjectSnapshotManager. I feel like these go a bit far and there's a way to do this without breaking the contract of those APIs.
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectChangeEventArgs.cs
Outdated
Show resolved
Hide resolved
...or/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotManager.Entry.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/ProjectSnapshotManager.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
approved these changes
Sep 4, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chris found these to be problematic in his branch where he enabled the source generator, but fortunately they're simply unnecessary in cohosting.