Fix @inherits mapping for fuse #10985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/razor-compiler for review please :) |
jjonescz
approved these changes
Oct 9, 2024
|
@dotnet/razor-compiler for a second review please :) |
DustinCampbell
approved these changes
Oct 9, 2024
This was referenced Oct 15, 2024
chsienki
added a commit
to chsienki/razor-tooling
that referenced
this pull request
Oct 18, 2024
* Make base type a token rather than a string * Track inherits source location and emit it when present * Add simple inherits test for components * Add razor page inherits test
333fred
added a commit
to 333fred/razor
that referenced
this pull request
Oct 23, 2024
* upstream/main: (290 commits) Add breaking changes document (dotnet#11064) Do not extract component into code block (dotnet#11069) Fix invalid setttings json (dotnet#11062) update MicrosoftSourceBuildIntermediatearcadePackageVersion Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512 Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512 Update source-build team references (dotnet#11032) Handle EditorRequired *Changed/*Expression parameters (dotnet#11043) Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213 Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213 Avoid ambiguous `object` reference in generic component recovery (dotnet#11053) Move culture info check (dotnet#11057) Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241015.1 Fix code actions integration tests Add option for format on paste (dotnet#11039) Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs Fix merge to 17.12 version Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs Ensure model directives are mapped at runtime (dotnet#11007) Fix @inherits mapping for fuse (dotnet#10985) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuse wasn't mapping the
[type]portion of the@inherits [type]directive. We now track the[type]as a token rather than just a string, so we can also track it's source location if it came from source.Most of the changes just come from changing it from a string type, which was almost entirely mechanical. I tried to keep the commit history clean, so it might make sense to review commit-by-commit.
Partially solves #10963
Note: the inherits directive interacts with the
@modeldirective too. That's not yet mapped, and in order to do so I'll need to make more changes here, but the diff seemed big enough that it was worth getting this out for review as its own item.