Cohosted Code Actions Part 2: Re-layout in advance of moving down #11083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be no changes in this commit other than those two syntax constructs
ryzngard
approved these changes
Oct 24, 2024
DustinCampbell
approved these changes
Oct 24, 2024
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/FormattingUtilities.cs
Outdated
Show resolved
Hide resolved
...pNetCore.Razor.LanguageServer.Test/CodeActions/CSharp/DefaultCSharpCodeActionProviderTest.cs
Outdated
Show resolved
Hide resolved
Part of #10742 This is the final step before actually doing something cohosting related: Move things to the Workspaces layer and extract services from the endpoints. Definitely more work to do on the services to make them usable for cohosting, but those diffs will at least be easier to view in isolation. Commit-at-a-time is presumably a much better experience since so many files moved, and namespaces changed, which I isolated to separate commits.
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10742
The next round of changes is to introduce the right abstractions so that the bulk of the code actions code can be moved to the Workspaces layer successfully.
At least I think I got it all :D
Reviewing commit at a time probably makes sense, but up to you.