Use an OOP service for getting compilation info from Roslyn #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Nov 3, 2024
|
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/589851 |
DustinCampbell
approved these changes
Nov 5, 2024
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/CompilationInfo.cs
Outdated
Show resolved
Hide resolved
|
Retargeted this to main, as we took a revert for 17.13 in #11165, but I think I'll probably close this in time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes a regression in RPS, due to bytes allocated from creating a compilation.
In future I think its probably worth combining this and the tag helper provider, since all of it comes from a compilation, and combine into one OOP call, but given I'm targetting 17.13 I'm trying not to nerd snipe myself. If anything thinks that's important to do up front, let me know.