Add comment to keep package versions in sync with O#-roslyn #8424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamint
reviewed
Mar 14, 2023
| @@ -110,8 +110,12 @@ | |||
| <MicrosoftVisualStudioTextDataPackageVersion>$(MicrosoftVisualStudioPackagesVersion)</MicrosoftVisualStudioTextDataPackageVersion> | |||
| <MicrosoftVisualStudioTextImplementationPackageVersion>$(MicrosoftVisualStudioPackagesVersion)</MicrosoftVisualStudioTextImplementationPackageVersion> | |||
| <MicrosoftVisualStudioTextLogicPackageVersion>$(MicrosoftVisualStudioPackagesVersion)</MicrosoftVisualStudioTextLogicPackageVersion> | |||
| <!-- NOTE: The Microsoft.VisualStudio.Threading package version should be kept in sync with O#-Roslyn's version: | |||
| https://github.com/OmniSharp/omnisharp-roslyn/blob/d7555ebfb6c4d7c6811c58370322d3b092c0abf6/build/Packages.props#L65 --> | |||
There was a problem hiding this comment.
Should there be a target branch linked here instead of the blob?
There was a problem hiding this comment.
I think GitHub by default now copies line links via absolute commits. This might be so the intended linked line stays the same, as opposed to using a target branch where the line #s may change
adamint
approved these changes
Mar 14, 2023
333fred
reviewed
Mar 14, 2023
allisonchou
changed the title
333fred
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Versions.propsto ensure we don't hit this again