Merge Cohost feature branch into main #9786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some respects this is a temporary thing until we get proper options support in cohosting, but in other respects having the service just take the one option value it actually needs is much nicer
# Conflicts: # eng/Versions.props
This still leaves in place the text sync endpoints, and updates to the LSP servers project system, so that everything else functions as expected
This also nicely lets us Find All Refs on the Cohost feature flag and see all of the code that can be deleted :)
Brings semantic tokens to cohosting, so there is an easy visual indicator if things are working. Right now colours are disco on first open of a file, but are fixed with an edit. This is actually a good thing, as it will help me diagnose and improve the document system in cohosting.
Merged the PR from the couch thinking I'd actioned this feedback. Turned out I'd made the changes on my other machine but hadn't committed 🤦♂️
…side of the world (#9766) In theory this means the end of document sync issues forever! In practice there is one fire-and-forget async method call here, from a sync context, so edge cases will still creep in. But all of this code should be deleted eventually anyway :D
PR feedback from a merged PR
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9519
Now that the initial cohost PR has been merged, we don't need to use the feature branch any more. That means this PR, which is big, but all of the code in it has been reviewed, in #9761, #9766 and #9767.