Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Roslyn project info in cohost endpoints #9805
Use Roslyn project info in cohost endpoints #9805
Changes from 8 commits
61e378d
b2fc07d
1c9c4d1
92f1ff3
209295e
2d8218e
7dffc15
813b80c
484bf6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a
PooledArrayBuilder
if the result will regularly be larger than 4 items.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean if it will be less than 4 items? If it's more than 4, doesn't the
PooledArrayBuilder
just switch to using theArrayBuilderPool
anyway?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having said that, I just copied this code as is, and it can be improved slightly by specifying a capacity at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry - I meant "less than 4 items".
PooledArrayBuilder
can help avoid starvation of theArrayBuilderPool
and is useful when smaller arrays are expected. I'm not 100% sure whatGetRelatedDocuments
means. Based on the code and the name of the map, I would guess it means, "the documents that use this import"? If so,ArrayBuilderPool
is probably the way to go.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's my reading too, and I agree. Thanks for confirming