Move SB metadata to intermediates #9893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
approved these changes
Feb 2, 2024
mthalman
reviewed
Feb 2, 2024
eng/Versions.props
Outdated
Comment on lines
72
to
76
| <MicrosoftSourceBuildIntermediateroslynPackageVersion>4.10.0-1.24072.4</MicrosoftSourceBuildIntermediateroslynPackageVersion> | ||
| <MicrosoftVisualStudioLanguageServicesPackageVersion>4.10.0-1.24072.4</MicrosoftVisualStudioLanguageServicesPackageVersion> | ||
| <MicrosoftSourceBuildIntermediatearcadeVersion>8.0.0-beta.24081.5</MicrosoftSourceBuildIntermediatearcadeVersion> | ||
| <MicrosoftDotNetXliffTasksPackageVersion>1.0.0-beta.23475.1</MicrosoftDotNetXliffTasksPackageVersion> | ||
| <MicrosoftSourceBuildIntermediatexlifftasksVersion>1.0.0-beta.23475.1</MicrosoftSourceBuildIntermediatexlifftasksVersion> |
There was a problem hiding this comment.
I thought we didn't want unused properties to be here.
There was a problem hiding this comment.
Because the group is Automated, if these are missing, errors like Missing version variable 'MicrosoftSourceBuildIntermediatearcadeVersion' in the 'Automated' property group occur. The same thing happened in aspnetcore.
aspnetcore failed build: https://github.com/dotnet/aspnetcore/pull/53749/checks?check_run_id=21128753365
mthalman
approved these changes
Feb 2, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.
The changes include:
Related to dotnet/source-build#3373 and dotnet/source-build#4073