Fix API approvals code.

dotnet · Sep 25, 2020 · 3e5916e · 3e5916e
1 parent 7e796ca
commit 3e5916e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/Rx.NET/Source/tests/Tests.System.Reactive.ApiApprovals/Api/ApiApprovalTests.cs b/Rx.NET/Source/tests/Tests.System.Reactive.ApiApprovals/Api/ApiApprovalTests.cs
@@ -7,20 +7,19 @@
 using System.Linq;
 using System.Reflection;
 using System.Threading.Tasks;
-using Verify;
+using VerifyTests;
 using VerifyXunit;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace ReactiveTests.Tests.Api
 {
     public class ApiApprovalTests :
         VerifyBase
     {
-        VerifySettings verifySettings;
+        private readonly VerifySettings verifySettings;
 
-        public ApiApprovalTests(ITestOutputHelper output) :
-            base(output)
+        public ApiApprovalTests()
+            : base()
         {
             verifySettings = new VerifySettings();
             verifySettings.UseExtension("cs");
@@ -64,6 +63,7 @@ private static string Filter(string text)
                                                         .Where(l => !l.StartsWith("[assembly: AssemblyFileVersion("))
                                                         .Where(l => !l.StartsWith("[assembly: AssemblyInformationalVersion("))
                                                         .Where(l => !l.StartsWith("[assembly: System.Reflection.AssemblyMetadata(\"CommitHash\""))
+                                                        .Where(l => !l.StartsWith("[assembly: System.Reflection.AssemblyMetadata(\"RepositoryUrl\""))
                                                         .Where(l => !string.IsNullOrWhiteSpace(l))
             );
         }

diff --git a/Rx.NET/Source/tests/Tests.System.Reactive.ApiApprovals/DiffPlexReporter.cs b/Rx.NET/Source/tests/Tests.System.Reactive.ApiApprovals/DiffPlexReporter.cs
@@ -2,6 +2,8 @@
 // The .NET Foundation licenses this file to you under the MIT License.
 // See the LICENSE file in the project root for more information. 
 
+#nullable enable
+
 using System;
 using System.IO;
 using System.Threading.Tasks;
@@ -13,9 +15,9 @@ namespace ReactiveTests.Tests
 {
     public static class DiffPlexReporter
     {
-        public static async Task Report(string receivedFile, string verifiedFile)
+        public static Task Report(string receivedFile, string verifiedFile, string? message)
         {
-            #if(!DEBUG)
+#if (!DEBUG)
             var receivedText = File.ReadAllText(receivedFile);
             var verifiedText = File.ReadAllText(verifiedFile);
             var diffBuilder = new InlineDiffBuilder(new Differ());
@@ -38,7 +40,9 @@ public static async Task Report(string receivedFile, string verifiedFile)
 
                 Console.WriteLine("{0}{1}", prefix, line.Text);
             }
-            #endif
+#endif
+
+            return Task.CompletedTask;
         }
     }
 }