Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-empty stack traces for operator exceptions. #1324

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

bartdesmet
Copy link
Collaborator

Improves #1235 by ensuring there's a StackTrace for operators such as SingleAsync when propagating on OnError exception they've created themselves. Because there's no stack to unwind (observer.OnError goes "the other way"), the exception info is limited to the current frame (e.g. OnCompleted in SingleAsync noticing there was no element and thus propagating an InvalidOperationException). At the very least, it gives a clue about the operator that caused it. Further root cause analysis remains a debugging task (e.g. why the sequence produced no elements) but this can help to steer investigations.

@bartdesmet bartdesmet merged commit b2d4902 into main Sep 30, 2020
@bartdesmet bartdesmet deleted the dev/bartde/slightly_better_exceptions branch September 30, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant