AsyncRx: Avoid closure allocations in Linq-operators when only the source-observable is captured. #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. We can also mark lambdas without a closure as static from now on. |
|
I'll update this PR tomorrow to enable C# 9 |
…enable the latest C#-version but other properties might make sense as well towards a CI build / NuGet-release.
Did it in a separate PR in #1365 because it'll need separate review w.r.t. all the CI properties. @clairernovotny Would you please have a look? |
|
Lambdas have been marked static. |
cabauman
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids quite a few allocations of closures for Linq-operator-creation when the only object that would have been captured is the source-observable. More closure-allocation improvements may follow.