Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable #nullable for some of the disposable types. #1369

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

bartdesmet
Copy link
Collaborator

First few #nullable introductions for disposable types. Note that Disposable properties on 3 of these types are now marked as ? because they can return null.

More to come for the composite variants of disposables. The rub with all of these (and the query operators after inlining disposable logic everywhere) is that all the helper methods use ref parameters and often need to change to IDisposable? to be callable, but then the call site does not have a guarantee about assignment. So, for now, we're stuck with these helpers remaining null-oblivious.

@bartdesmet bartdesmet merged commit 53bf70f into main Oct 3, 2020
@bartdesmet bartdesmet deleted the dev/bartde/rx_nullable_part23 branch October 3, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant