Enable #nullable for some of the disposable types. #1369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First few
#nullable
introductions for disposable types. Note thatDisposable
properties on 3 of these types are now marked as?
because they can returnnull
.More to come for the composite variants of disposables. The rub with all of these (and the query operators after inlining disposable logic everywhere) is that all the helper methods use
ref
parameters and often need to change toIDisposable?
to be callable, but then the call site does not have a guarantee about assignment. So, for now, we're stuck with these helpers remaining null-oblivious.