Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These WinForms and WPF tests go all the way back to a private test infrastructure (prior to OSS) and later MsTest, and never were hardened against concurrent execution of test cases; they were always run sequentially. This has led to flakiness at some point later, maybe during the migration to Xunit, and it seems nobody ever addressed this.
This PR hardens things in a few ways:
Application.Exit
on a different thread.After this goes in, we can likely re-enable some tests that were disabled, possibly because folks observed flakiness (e.g.
ObserveOn
tests getting stuck indefinitely because another test case ranApplication.Exit
and killed the message loop from underneath the test).