Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all exception rethrows use EDI. #1391

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

bartdesmet
Copy link
Collaborator

Code got into BehaviorSubject<T> that didn't leverage IExceptionServices to perform the rethrow. This mechanism was part of the PlatformServices separation and has also been used for hosting layers. Restore this for BehaviorSubject<T>.

Also simplifying all of the use sites of ThrowIfNotNull by using ?. which works well with flow analysis and #nullable tracking (given the DoesNotReturn attribute on Throw and the lack of such an attribute that can make ThrowIfNotNull conditionally non-returning based on the nullability of the operand; DoesNotReturnIf only works with Boolean predicates).

@bartdesmet bartdesmet merged commit 0df6533 into main Oct 7, 2020
@bartdesmet bartdesmet deleted the dev/bartde/simpler_exception_rethrow branch October 7, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant