Ensure all exception rethrows use EDI. #1391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code got into
BehaviorSubject<T>
that didn't leverageIExceptionServices
to perform the rethrow. This mechanism was part of thePlatformServices
separation and has also been used for hosting layers. Restore this forBehaviorSubject<T>
.Also simplifying all of the use sites of
ThrowIfNotNull
by using?.
which works well with flow analysis and#nullable
tracking (given theDoesNotReturn
attribute onThrow
and the lack of such an attribute that can makeThrowIfNotNull
conditionally non-returning based on the nullability of the operand;DoesNotReturnIf
only works with Boolean predicates).