Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Refactor Linq operator unit tests into separate files/classes #527

Merged
merged 2 commits into from
May 26, 2018

Conversation

akarnokd
Copy link
Collaborator

This PR refactors the various operator unit tests into their separate files and allows:

  • locating tests of an operator by name instead of a category,
  • running tests of one operator instead of a group of operators.

@akarnokd
Copy link
Collaborator Author

akarnokd commented May 24, 2018

Now the fun part. Finding out which are those 2 tests that got lost:

image

image

@clairernovotny
Copy link
Member

@akarnokd that could be due to the removal of some of the TFM's. We removed netcoreapp1.1, so that could account for one test depending on what the base version is.

@akarnokd
Copy link
Collaborator Author

I was verifying periodically if the test runner still has the original 3534 test listed and it still shows me that:

image

that could be due to the removal of some of the TFM's.

This shows 7010 as well:

image

@danielcweber
Copy link
Collaborator

Can you build it locally through the script, it should open a coverage report at the end, if it didn't decrease, it'll be good to merge.

Copy link
Collaborator

@danielcweber danielcweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok if the mystery of the lost tests is solved.

@akarnokd
Copy link
Collaborator Author

Looks like there were changes on the master earlier and I compared against another PR probably pointing further back in time.

@akarnokd akarnokd force-pushed the RefactorLinqTests branch from cf7fd3f to edb74a1 Compare May 25, 2018 15:50
@clairernovotny clairernovotny merged commit 1a4c2f2 into dotnet:master May 26, 2018
@akarnokd akarnokd deleted the RefactorLinqTests branch May 26, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants