4.x: Inline Disposable.Create #580
Conversation
| SetUpstream(StableCompositeDisposable.Create(fstSubscription, sndSubscription, fstO, sndO)); | ||
| // clearing the queue should happen under the lock | ||
| // as they are plain Queue<T>s, not concurrent queues. | ||
| lock (_gate) |
There was a problem hiding this comment.
This has now become dangerous, _gate might not be assigned.
There was a problem hiding this comment.
Can Dispose happen before Run executes?
There was a problem hiding this comment.
Hopefully not in our code, but it's good to assume everything might be disposed right away. By the same reasoning, Run will definitely happen when the Sink was created, so the gate might be created while constructing.
| { | ||
| Disposable.TryDispose(ref _subscriptions[i]); | ||
| } | ||
| lock (_gate) |
There was a problem hiding this comment.
This has now become dangerous, _gate might not be assigned.
There was a problem hiding this comment.
I'll move the creation into the constructor so it will be guaranteed to exist.
| { | ||
| var o = new SourceObserver(this, i); | ||
| Disposable.SetSingle(ref _subscriptions[i], srcs[i].SubscribeSafe(o)); | ||
| _gate = new object(); |
There was a problem hiding this comment.
I know it's safe now but please just make it a readonly field and assign it in the declaration.
This PR inlines the
Disposable.Create(Action)invocations, saving on an allocation and some indirection.