Rework SelectMany #604
Merged
Rework SelectMany #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
Jun 18, 2018
| @@ -875,9 +872,7 @@ public override void Run(IObservable<TSource> source) | |||
| { | |||
| _isStopped = false; | |||
There was a problem hiding this comment.
I'm not sure why setting to default here is even necessary. The field is already initialized to false upon class instantiation. By removing this, you don't even need to override Run.
There was a problem hiding this comment.
Right, I figured this might have been from a time where Sinks were supposed to run more than once.
There was a problem hiding this comment.
Even then it makes no sense as sinks had per subscription state. Having the same sink instance service two indenpendent flows invites state clash and concurrency errors.
| @@ -1110,9 +1109,7 @@ public override void Run(IObservable<TSource> source) | |||
| { | |||
| _isStopped = false; | |||
There was a problem hiding this comment.
Same here, init to default can be omitted.
akarnokd
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save some allocations and inline disposables.