Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-recursive extensions for IScheduler allowing to return an IDisposable #710

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Add non-recursive extensions for IScheduler allowing to return an IDisposable #710

merged 1 commit into from
Jun 29, 2018

Conversation

danielcweber
Copy link
Collaborator

This will enable more usages of non-recursive scheduling. Before C# 7.3, the compiler will complain about some ambiguities, so we increase the language version.

@akarnokd
Copy link
Collaborator

"System.Security.VerificationException : Operation could destabilize the runtime."?

@danielcweber
Copy link
Collaborator Author

Maybe dotnet/roslyn#27382. Investigating.

@danielcweber
Copy link
Collaborator Author

Removing [assembly: AllowPartiallyTrustedCallers] makes it disappear. I have to investigate which direction to go here, the language version has to be able to progress.

@danielcweber
Copy link
Collaborator Author

@danielcweber
Copy link
Collaborator Author

Removing readonly from this also does the trick.

@clairernovotny
Copy link
Member

Thread says to remove APTCA:
https://twitter.com/onovotny/status/1012392223755980800

@clairernovotny
Copy link
Member

And the docs are changing to say this directly too: dotnet/docs#6199

…sposable. This will enable more usages of non-recursive scheduling. Before C# 7.3, the compiler will complain about some ambiguities, so we increase the language version.
@danielcweber danielcweber merged commit b5a0ad5 into dotnet:master Jun 29, 2018
@danielcweber danielcweber deleted the AddMoreNonRecursiveScheduleExtensions branch June 29, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants