New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: simplify default(X) usages #712

Merged

danielcweber merged 2 commits into dotnet:master from akarnokd:SimplifyDefaultExpr

Jun 29, 2018

Collaborator

akarnokd commented Jun 28, 2018

Simplify default(X) where X is inferable from the usage.
Aggregate:
- don't initialize to default values
- clear accumulation upon failure or completion
LastAsync:
- don't initialize to default values
- clear accumulation upon failure or completion
LastOrDefaultAsync:
- don't initialize to default values
- clear accumulation upon failure or completion
Upgrade Test.System.Reactive project to C# 7.1

akarnokd and others added 2 commits

June 28, 2018 21:46


          4.x: simplify default(X) usages

70741b9


          Merge branch 'master' into SimplifyDefaultExpr

76a070b

danielcweber merged commit 0d41a88 into dotnet:master

clairernovotny reviewed

View reviewed changes

Rx.NET/Source/tests/Tests.System.Reactive/Tests.System.Reactive.csproj

@@ @@ -2,6 +2,7 @@ @@
                 <PropertyGroup>
                   <TargetFrameworks>net46;netcoreapp2.0</TargetFrameworks>
                   <NoWarn>$(NoWarn);CS0618</NoWarn>
+                  <LangVersion>7.1</LangVersion>

Member

clairernovotny Jun 29, 2018

This should be removed. The LangVersion is set to latest in the Directory.Build.props. This lowers it.

akarnokd deleted the SimplifyDefaultExpr branch

June 29, 2018 12:56

akarnokd mentioned this pull request

4.1.0 release preparations #607

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet