Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable switching Rx versions for benchmarks. #731

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Enable switching Rx versions for benchmarks. #731

merged 2 commits into from
Jul 3, 2018

Conversation

danielcweber
Copy link
Collaborator

This PR makes the referenced Rx-version switchable. It works by force-overriding the used Rx-version (if taken from nuget). It can be combined with the standalone solution from #730, the solution should then have configurations that match the project configurations (current, Rx3.1.1, etc), so the config can easily be switched in the VS dropdown.

@danielcweber danielcweber changed the title Propose an extension to https://github.com/dotnet/reactive/pull/730 Propose an extension to #730 Jul 2, 2018
@akarnokd
Copy link
Collaborator

akarnokd commented Jul 2, 2018

I'm not sure how this would work with #730 as it is a separate solution and has no access to CURRENT.

Besides, I found it much easier to keep the NuGet manager open and switch the Rx library with one dropdown and one update click. This PR requires clicking on the releases dropdown, clicking on the configuration manager, clicking on the configuration dropdown, clicking on it again because the first click just selects the cell, click on the setting, close the window and finally clean the solution.

Regardless, I don't see a reason to keep both of them around and copy benchmarks between the two.

@danielcweber
Copy link
Collaborator Author

danielcweber commented Jul 3, 2018

I'm not sure how this would work with #730 as it is a separate solution and has no access to CURRENT.

Unless you reference the project in the separate solution.

Besides, I found it much easier to keep the NuGet manager open and switch the Rx library with one dropdown and one update click.

That's what I'm saying, the hybrid of #730 and #731 can have both, access to the current sources and easier access to the configuration.

I'm good with either.

@danielcweber danielcweber changed the title Propose an extension to #730 Enable switching Rx versions for benchmarks. Jul 3, 2018
@danielcweber danielcweber merged commit a1a6129 into dotnet:master Jul 3, 2018
@danielcweber danielcweber deleted the SwitchableComparisonBenchmarks branch July 3, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants