4.x: Fix long sequence ObserveOn StackOverflowException upon Dispose #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweber
reviewed
Jul 3, 2018
| // Don't return the disposable of Schedule() because that may chain together | ||
| // a long string of ScheduledItems causing StackOverflowException upon Dispose() | ||
| var d = recursiveScheduler.Schedule(this, DRAIN_SHORT_RUNNING); | ||
| Disposable.TrySetMultiple(ref _task, d); | ||
| } | ||
| return Disposable.Empty; |
There was a problem hiding this comment.
Shouldn't it at least return this here?
There was a problem hiding this comment.
That would recurse upon calling Dispose() for no practical purpose. The public void Dispose() takes care of the cleanup when the downstream disposes, including the outstanding tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
StackOverflowExceptionwhen a long runningObserveOn(> 100.000 items) gets disposed due to theScheduledItems linked together when using the recursive scheduler.The fix is to track the next recursive task's disposable directly and not allow the chaining to happen. For reference, this is the same effect that had to be considered in the improved
RangeandToObservableimplementations.