4.x: Improve RefCount() internals #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The purpose of that unit test was to ensure that, should base.Run(...) dispose the Sink synchronously, it will be discovered and the call to Connect will be avoided. |
|
Only in the synchronous case? What about an async completing source? Should we detect any termination and prevent further connections? |
|
I guess 99% of the time |
danielcweber
reviewed
Jul 6, 2018
| // only the currently known connection is affected | ||
| // and a connection from a concurrent reconnection won't | ||
| // interfere | ||
| Disposable.SetSingle(ref conn._disposable, _parent._source.Connect()); |
There was a problem hiding this comment.
Checked it with the unit test from #773 and it's red. It should be enough to guard this by if (!Disposable.GetIsDisposed(ref conn._disposable)) to avoid connecting and immediately disconnecting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dedicated connection state object to avoid reconnection and disconnection interference as well as some comments about what each part of the algorithm does.
(Note: it does not add the unit test from #773 as it is unclear to me that unit test is supposed to ensure, an old or new behavior?).