Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a warning if the half-serializer ignores a value in ForwardOnNext. #807

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Emit a warning if the half-serializer ignores a value in ForwardOnNext. #807

merged 1 commit into from
Aug 28, 2018

Conversation

danielcweber
Copy link
Collaborator

In case an upstream observable doesn't behave according to the protocol, the half-serializer will swallow values in ForwardOnNext. While the guidelines state that it is safe to assume that upstreams behave properly, this behaviour is different to <4.1.0 and it is fair to produce a warning.

@danielcweber
Copy link
Collaborator Author

danielcweber commented Aug 28, 2018

@onovotny I fear we got a hanging check here...

@clairernovotny
Copy link
Member

clairernovotny commented Aug 28, 2018

Hmm...looks like they renamed how build definitions are reported.

@clairernovotny clairernovotny merged commit 4ed23b8 into dotnet:master Aug 28, 2018
@danielcweber danielcweber deleted the EmitWarningInHalfserializer branch August 28, 2018 14:28
@danielcweber danielcweber mentioned this pull request Oct 1, 2018
danielcweber added a commit that referenced this pull request Oct 1, 2018
Prepare bugfix release 4.1.1. Contains #806, #807, #809, #816.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants