Fix wrong usage of ISchedulerLongRunning in ObserveOn #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimized
ObserveOn
was using theISchedulerLongRunning
scheduler incorrectly. This type of scheduler is meant to be kept alive by possibly blocking the backing thread as long as the sequence is still active.Additional changes:
ISchedulerLongRunning
cases from theObserveOnObserverNew
implementation.ObserveOnObserverNew
no longer supports error delaying (Based on unit tests, it was expected only fromISchedulerLongRunning
schedulers anyway).ObserveOnObserverLongRunning
dedicated to working withISchedulerLongRunning
.ObserveOn
extension method.AsLongRunning()
no longer returns anISchedulerLongRunning
implementation.Fixes #877