Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Microsoft.Bcl.AsyncInterfaces for net461 and netstandard2.0 #900

Merged
merged 3 commits into from
May 12, 2019

Conversation

clairernovotny
Copy link
Member

Fixes #897

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #900 into master will decrease coverage by 2.63%.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   65.51%   62.87%   -2.64%     
==========================================
  Files         168      163       -5     
  Lines       30166    28710    -1456     
  Branches    20523    19800     -723     
==========================================
- Hits        19762    18052    -1710     
+ Misses       2499     2119     -380     
- Partials     7905     8539     +634
Flag Coverage Δ
#ixnet 62.87% <47.36%> (-2.64%) ⬇️
Impacted Files Coverage Δ
...tive.Async/System/Linq/Operators/IgnoreElements.cs 50% <0%> (-11.85%) ⬇️
.../System.Linq.Async/System/Linq/Operators/Lookup.cs 83.33% <0%> (ø) ⬆️
...e/System.Linq.Async/System/Linq/Operators/Union.cs 59.17% <0%> (-10.87%) ⬇️
....Interactive.Async/System/Linq/Operators/Concat.cs 41.22% <0%> (-8.17%) ⬇️
....Async/System/Linq/Operators/ElementAtOrDefault.cs 77.08% <0%> (ø) ⬆️
....Interactive.Async/System/Linq/Operators/Repeat.cs 44.44% <0%> (-11.39%) ⬇️
...m.Linq.Async/System/Linq/AsyncEnumerableHelpers.cs 62.16% <0%> (ø)
...stem.Linq.Async/System/Linq/Operators/Aggregate.cs 60% <0%> (ø) ⬆️
...m.Interactive.Async/System/Linq/Operators/Catch.cs 37.41% <0%> (-12.72%) ⬇️
...stem.Linq.Async/System/Linq/Operators/Utilities.cs 50% <0%> (ø)
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641a751...ca93b96. Read the comment docs.

@clairernovotny clairernovotny merged commit df75c21 into master May 12, 2019
@clairernovotny clairernovotny deleted the use-bcl-iae branch May 12, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using Microsoft.Bcl.AsyncInterfaces for IAsyncEnumerable
1 participant