Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code of hand-rolled iterators #905

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

bartdesmet
Copy link
Collaborator

Remove dead code predicated by !USE_ASYNC_ITERATOR given we've switched over to use iterators across the board.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #905 into master will increase coverage by 3.12%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   62.24%   65.37%   +3.12%     
==========================================
  Files         165      165              
  Lines       32331    25436    -6895     
  Branches    24399    18438    -5961     
==========================================
- Hits        20124    16628    -3496     
+ Misses       2565     2069     -496     
+ Partials     9642     6739    -2903
Flag Coverage Δ
#ixnet 65.37% <50%> (+3.12%) ⬆️
Impacted Files Coverage Δ
...tem.Interactive.Async/System/Linq/Operators/Amb.cs 34.63% <ø> (-8.42%) ⬇️
...ce/System.Linq.Async/System/Linq/Operators/Cast.cs 76.92% <ø> (+2.53%) ⬆️
....Interactive.Async/System/Linq/Operators/Repeat.cs 57.62% <ø> (+10.35%) ⬆️
...stem.Interactive.Async/System/Linq/Operators/Do.cs 31.27% <ø> (-11.1%) ⬇️
...ystem.Linq.Async/System/Linq/Operators/SkipLast.cs 77.55% <ø> (+1.94%) ⬆️
...em.Interactive.Async/System/Linq/Operators/Scan.cs 38.55% <ø> (-7.02%) ⬇️
...stem.Linq.Async/System/Linq/Operators/SkipWhile.cs 67.69% <ø> (+10.12%) ⬆️
.../System.Linq.Async/System/Linq/Operators/OfType.cs 79.31% <ø> (+5.15%) ⬆️
...m.Interactive.Async/System/Linq/Operators/Using.cs 55.07% <ø> (+14.65%) ⬆️
...tem.Linq.Async/System/Linq/Operators/SelectMany.cs 58.89% <ø> (+0.76%) ⬆️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3529def...6335194. Read the comment docs.

@bartdesmet bartdesmet merged commit 447c3fb into master May 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the UseAsyncIterators branch May 24, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant