Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor cleanup #906

Merged
merged 1 commit into from
May 24, 2019
Merged

Some minor cleanup #906

merged 1 commit into from
May 24, 2019

Conversation

bartdesmet
Copy link
Collaborator

Remove some unused using and use shadowing of local function parameters in one more case.

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #906 into master will increase coverage by 0.14%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   65.37%   65.51%   +0.14%     
==========================================
  Files         165      165              
  Lines       25436    25429       -7     
  Branches    18438    18351      -87     
==========================================
+ Hits        16628    16661      +33     
- Misses       2069     2132      +63     
+ Partials     6739     6636     -103
Flag Coverage Δ
#ixnet 65.51% <37.5%> (+0.14%) ⬆️
Impacted Files Coverage Δ
...ce/System.Linq.Async/System/Linq/Operators/Join.cs 72.89% <ø> (+1.03%) ⬆️
...stem.Linq.Async/System/Linq/Operators/Intersect.cs 78.78% <ø> (+2.31%) ⬆️
...stem.Linq.Async/System/Linq/Operators/SkipWhile.cs 68% <ø> (+0.3%) ⬆️
...stem.Linq.Async/System/Linq/Operators/TakeWhile.cs 73.33% <ø> (+1.64%) ⬆️
....Linq.Async/System/Linq/Operators/SequenceEqual.cs 76.27% <100%> (+2.07%) ⬆️
...tem.Linq.Async/System/Linq/Operators/SelectMany.cs 59.03% <28.57%> (+0.14%) ⬆️
.../System.Linq.Async/System/Linq/Operators/Repeat.cs 72.61% <0%> (-1.2%) ⬇️
...rce/System.Linq.Async/System/Linq/Operators/Zip.cs 74.31% <0%> (ø) ⬆️
...System.Linq.Async/System/Linq/Operators/Reverse.cs 73.58% <0%> (ø) ⬆️
...rce/System.Linq.Async/System/Linq/Operators/Any.cs 74.15% <0%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447c3fb...5deb0f1. Read the comment docs.

@bartdesmet bartdesmet merged commit ad58020 into master May 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the MiscCleanup branch May 24, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant