Ix: Do not dispose the enumerator while enumerating in the ToObservable operator. #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartdesmet
requested changes
Jun 5, 2019
Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToObservable.cs
Outdated
Show resolved
Hide resolved
quinmars
commented
Jun 6, 2019
Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToObservable.cs
Outdated
Show resolved
Hide resolved
bartdesmet
reviewed
Jun 6, 2019
Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToObservable.cs
Outdated
Show resolved
Hide resolved
akarnokd
approved these changes
Nov 14, 2019
|
Review by @bartdesmet still needed? His earlier review has been adressed by @quinmars if I see this correctly. |
|
Somehow, github could not link the commit to @bartholinie. Does any one know how to make that work? |
|
"Jens Chr authored and quinmars committed 12 hours ago". Commit info is preserved, isn't it? |
akarnokd
approved these changes
Nov 20, 2019
|
The requested change was about the recursion and has been adressed, right? Would merge after checks pass. |
|
Right the commit info is preserve, but @bartholinie is not listed in the contributors list. |
|
@onovotny @bartdesmet Can we have a Linq.Async / Ix.Async preview that would contain this fix? Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @danielcweber the current implementation of
ToObservablemay violate the contract ofIAsyncEnumerator, because it is possible to callDisposeAsyncduring an on goingMoveNextAsynccall.#423 (comment)