Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/1774 duplicate cryptography codes #1793

Merged

Conversation

dotpaul
Copy link
Contributor

@dotpaul dotpaul commented Aug 27, 2018

Fix for #1774

Consolidating the crypto rule implementations into the NetCore analyzers.

@dotpaul dotpaul requested a review from mavasani August 27, 2018 19:07
@dotpaul
Copy link
Contributor Author

dotpaul commented Aug 27, 2018

@timhermann fyi

@dotpaul
Copy link
Contributor Author

dotpaul commented Aug 28, 2018

@dotnet-bot retest this please

@dotpaul dotpaul changed the title Fixes/1774 duplicate cryptography codes WIP Fixes/1774 duplicate cryptography codes Aug 28, 2018
@dotpaul dotpaul changed the title WIP Fixes/1774 duplicate cryptography codes Fixes/1774 duplicate cryptography codes Aug 28, 2018
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't look at the tests as I presume you are just moving them from one project to another.

@dotpaul dotpaul merged commit 100d223 into dotnet:master Aug 29, 2018
@dotpaul dotpaul deleted the fixes/1774-duplicate-cryptography-codes branch August 31, 2018 18:26
@mavasani mavasani mentioned this pull request Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants