Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DiagnosticResult from Microsoft.CodeAnalysis.Testing #1801

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Use DiagnosticResult from Microsoft.CodeAnalysis.Testing #1801

merged 1 commit into from
Sep 4, 2018

Conversation

sharwell
Copy link
Member

This change should simplify reviews of updates to use Microsoft.CodeAnalysis.Testing for other parts of the test suite.

@sharwell sharwell force-pushed the new-diagnosticresult branch from a0be7ba to 3684c1e Compare August 31, 2018 15:11
@sharwell sharwell mentioned this pull request Aug 31, 2018
Closed
mavasani
mavasani approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at each and every changed file, but overall the changes LGTM.

@sharwell sharwell merged commit bcf2215 into dotnet:master Sep 4, 2018
@sharwell sharwell deleted the new-diagnosticresult branch September 4, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @mavasani