Do not define finalizers for types derived from MemoryManager<T> #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto no_finalizer
sharwell
reviewed
Apr 1, 2020
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Apr 1, 2020
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Apr 1, 2020
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Apr 1, 2020
...soft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManagerTests.cs
Outdated
Show resolved
Hide resolved
...soft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManagerTests.cs
Outdated
Show resolved
Hide resolved
...soft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManagerTests.cs
Outdated
Show resolved
Hide resolved
jeffhandley
reviewed
Apr 1, 2020
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3461 +/- ##
========================================
Coverage 95.28% 95.28%
========================================
Files 1009 1011 +2
Lines 231260 231482 +222
Branches 14939 14958 +19
========================================
+ Hits 220350 220571 +221
Misses 9259 9259
- Partials 1651 1652 +1 |
sharwell
reviewed
Apr 1, 2020
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
...soft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManagerTests.cs
Outdated
Show resolved
Hide resolved
...soft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManagerTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Apr 1, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
...Microsoft.NetCore.Analyzers/Runtime/DoNotDefineFinalizersForTypesDerivedFromMemoryManager.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#33768