Fixer: Prefer Memory overloads for Stream async Read/Write methods

[carlossanlop]

Fixes dotnet/runtime#33790

Summary

If the user invokes any of these methods from an object that is or inherits from Stream:

ReadAsync(byte[] buffer, int offset, int count)
ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
WriteAsync(byte[] buffer, int offset, int count)
WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)

We should suggest to instead use:

ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken)
WriteAsync(ReadOnlyMemory<byte> buffer, CancellationToken cancellationToken)

Works for both C# and VB.
All unit tests are passing locally.

[codecov]

Codecov Report

Merging #3592 into master will decrease coverage by 0.00%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##           master    #3592      +/-   ##
==========================================
- Coverage   95.15%   95.15%   -0.01%     
==========================================
  Files        1069     1070       +1     
  Lines      242339   242302      -37     
  Branches    15753    15765      +12     
==========================================
- Hits       230596   230553      -43     
- Misses      10000    10002       +2     
- Partials     1743     1747       +4     

[codecov]

Codecov Report

Merging #3592 into master will increase coverage by 0.00%.
The diff coverage is 97.32%.

@@           Coverage Diff            @@
##           master    #3592    +/-   ##
========================================
  Coverage   95.15%   95.16%            
========================================
  Files        1069     1071     +2     
  Lines      242339   243061   +722     
  Branches    15753    15789    +36     
========================================
+ Hits       230596   231305   +709     
- Misses      10000    10003     +3     
- Partials     1743     1753    +10     

[carlossanlop]

I also need to resolve @mavasani 's request to group the description and title messages into one: #3586

[mavasani]

Overall, LGTM. Thanks for extensive tests. I should be good to sign off once the last set of suggestions are addressed.

[mavasani]

LGTM. I have couple more suggestions:

1. Use new MyCodeAction as MyCodeAction.Create will do the same thing as CodeAction.Create
2. Use localized title string without method name as the first argument for title.

[carlossanlop]

LGTM. I have couple more suggestions:

1. Use new MyCodeAction as MyCodeAction.Create will do the same thing as CodeAction.Create
2. Use localized title string without method name as the first argument for title.

Fixed, @mavasani. Thanks. I'll merge as soon as the build finishes.