Support foreach over parameters in DoNotCopyValue #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
reviewed
Oct 27, 2020
mavasani
reviewed
Oct 28, 2020
| // No special requirements | ||
| break; | ||
|
|
||
| case RefKind.RefReadOnly when operation.Syntax is CommonForEachStatementSyntax syntax && operation.SemanticModel.GetForEachStatementInfo(syntax).GetEnumeratorMethod is { IsReadOnly: true }: |
There was a problem hiding this comment.
This is getting too difficult to manage - IMO this analyzer is not sustainable unless rewritten as a flow-based analyzer. I'll let you decide how to take this forward.
There was a problem hiding this comment.
IMO this analyzer is not sustainable unless rewritten as a flow-based analyzer.
Flow-based analysis does not help here. Every language construct needs to be allow-listed as it is encountered. The only real alternative would be new language support or IL analysis.
mavasani
approved these changes
Oct 28, 2020
sharwell
force-pushed
the
foreach-readonly
branch
from
cc0c258 to
ac5f89f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4374 +/- ##
==========================================
- Coverage 95.79% 95.79% -0.01%
==========================================
Files 1170 1172 +2
Lines 266722 266801 +79
Branches 16063 16069 +6
==========================================
+ Hits 255511 255574 +63
- Misses 9155 9165 +10
- Partials 2056 2062 +6 |
sharwell
force-pushed
the
foreach-readonly
branch
from
ac5f89f to
21b4b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4368