Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2/4) Override Stream ReadAsync/WriteAsync Analyzer #4726

Merged
merged 25 commits into from
May 18, 2021
Merged

(2/4) Override Stream ReadAsync/WriteAsync Analyzer #4726

merged 25 commits into from
May 18, 2021

Commits on Jan 15, 2021

  1. Implement analyzer with basic tests

    @NewellClark
    NewellClark committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    a67832e View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Added more tests

    @NewellClark
    NewellClark committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    fbc706d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Add ProvideStreamMemoryBasedAsyncOverrides analyzer 

    Fix issue #33789
    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8b9cf92 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'dotnet/release/6.0.1xx-preview1' into i… 

    …ssue-33789
    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b6604e7 View commit details
    Browse the repository at this point in the history

  3. Forgot to MSBuild

    @NewellClark
    NewellClark committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    fe1d3b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/Prov… 

    …ideStreamMemoryBasedAsyncOverrides.cs

Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
    @NewellClark @Youssef1313
    NewellClark and Youssef1313 authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    4f667a7 View commit details
    Browse the repository at this point in the history

  2. Fix crash bug on illegal code 

    If there are multiple definitions of the same overridden method, the analyzer can crash due to uses of `SingleOrDefault` instead of `FirstOrDefault`.

To fix, I refactored `GetOverload` and `GetSymbolForOverridingMethod` into immutable-array-returning methods, and simply used `FirstOrDefault` or `SingleOrDefault` at each call-site as appropriate.
    @NewellClark
    NewellClark committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8940025 View commit details
    Browse the repository at this point in the history

  3. Rerun CI

    @NewellClark
    NewellClark committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    3f64c5e View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. Apply suggested changes

    @NewellClark
    NewellClark committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    f91a7f0 View commit details
    Browse the repository at this point in the history

  2. Rerun CI

    @NewellClark
    NewellClark committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    f072328 View commit details
    Browse the repository at this point in the history

  3. Forgot to msbuild /t:pack

    @NewellClark
    NewellClark committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    faac3a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2021

  1. Fix typo 

    Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
    @NewellClark @Youssef1313
    NewellClark and Youssef1313 authored Jan 24, 2021
    Configuration menu
    Copy the full SHA
    1940995 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Inline resource creation 

    As was requested on my other PRs.
    @NewellClark
    NewellClark committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    7123f46 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Apply requested changes 

    - Change ID to CA1842
    @NewellClark
    NewellClark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3925794 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into issue-33789

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    761578e View commit details
    Browse the repository at this point in the history

  3. Add newline to end of resx file

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    a4e6374 View commit details
    Browse the repository at this point in the history

  4. Add newline character

    @NewellClark
    NewellClark authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f481548 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Fix garbled unshipped.md markup

    @NewellClark
    NewellClark authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    b2dc2cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into issue-33789

    @NewellClark
    NewellClark authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    516e775 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Change ID to CA1844

    @NewellClark
    NewellClark committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    31b78e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx-preview4' into issue-33789

    @NewellClark
    NewellClark authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    a320e17 View commit details
    Browse the repository at this point in the history

  3. Fix failing CA

    @NewellClark
    NewellClark committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    81eda27 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Apply suggested changes 

    Fix possible crash when primitive types can't be loaded
    @NewellClark
    NewellClark committed May 17, 2021
    Configuration menu
    Copy the full SHA
    f70c6d8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Use simple names in diagnostic messages 

    - Remove usages of `MinimallyQualifiedFormat`
- Change message so it makes sense with simple names
    @NewellClark
    NewellClark committed May 18, 2021
    Configuration menu
    Copy the full SHA
    94ee770 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/6.0.1xx' into issue-33789

    @NewellClark
    NewellClark authored May 18, 2021
    Configuration menu
    Copy the full SHA
    4d7967b View commit details
    Browse the repository at this point in the history