port new security analyzers to net6 #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues Ensure key validation isn't explicitly disabled by setting the relevant setter on the validation object to false: * RequireExpirationTime * ValidateAudience * ValidateIssuer * ValidateLifetime Ensure key validation isn't implicitly disabled by having the relevant delegate always return true: * AudienceValidator * LifetimeValidator NOTE: There's another key implicit case for IssuerValidator, however the logic there is more complex and would require Data Flow Analysis (DFA). Since DFA has a different performance profile anyways, shipping these analyzers first which can be accomplished via static analysis. We also have CodeQL work in the pipe separately from this to address more complicated DFA flows.
* Fix nullref exception found during, added unit test
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx #5467 +/- ##
===================================================
- Coverage 95.54% 95.52% -0.02%
===================================================
Files 1269 1273 +4
Lines 289171 289661 +490
Branches 17453 17478 +25
===================================================
+ Hits 276277 276705 +428
- Misses 10559 10584 +25
- Partials 2335 2372 +37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of #5420