Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CA1305 to compare symbols #6356

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Refactor CA1305 to compare symbols #6356

merged 2 commits into from
Dec 21, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 15, 2022

Fixes #6052

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 15, 2022 11:23
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #6356 (6edc75e) into main (37c910d) will increase coverage by 0.00%.
The diff coverage is 87.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6356   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files        1362     1360    -2     
  Lines      315490   315500   +10     
  Branches    10187    10186    -1     
=======================================
+ Hits       303137   303148   +11     
+ Misses       9920     9918    -2     
- Partials     2433     2434    +1     

@mavasani mavasani enabled auto-merge December 21, 2022 10:12
@mavasani mavasani merged commit 7d75ca2 into dotnet:main Dec 21, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 21, 2022
@Youssef1313 Youssef1313 deleted the ca1305 branch December 21, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup CA1305 analyzer to correctly compare method symbols
2 participants