Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move tests to target .NET 7" #6429

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Revert "Move tests to target .NET 7" #6429

merged 1 commit into from
Jan 12, 2023

Conversation

mavasani
Copy link
Contributor

Reverts #6364 to fix the build break in the repo

@mavasani mavasani requested a review from a team as a code owner January 12, 2023 12:32
@Youssef1313
Copy link
Member

@mavasani Instead of reverting the PR, could you try targeting net8.0 instead?
I think the issue is that .NET 7 runtime isn't found starting with #6409

@mavasani
Copy link
Contributor Author

Okay, let me try on #6428

@Youssef1313
Copy link
Member

I'm also curious about the move to .NET 8 SDK too early?

There is no installer available in https://dotnet.microsoft.com/en-us/download, so we have to install nightly builds from https://github.com/dotnet/installer#table? This should at least by reflected in CONTRIBUTING.md if usage of .NET 8 SDK is kept

@mavasani
Copy link
Contributor Author

I'm also curious about the move to .NET 8 SDK too early?

Do you know which PR did that? I agree we should stay on .NET 7

@mavasani
Copy link
Contributor Author

I'm also curious about the move to .NET 8 SDK too early?

Do you know which PR did that? I agree we should stay on .NET 7

Seems like it happened with #6409

@Youssef1313
Copy link
Member

@mavasani Do we want to revert #6409 too?

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #6429 (356147f) into main (7b6ad7e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6429   +/-   ##
=======================================
  Coverage   96.14%   96.15%           
=======================================
  Files        1365     1365           
  Lines      317494   317494           
  Branches    10269    10269           
=======================================
+ Hits       305269   305273    +4     
+ Misses       9791     9787    -4     
  Partials     2434     2434           

@mavasani
Copy link
Contributor Author

Force merging to fix the build break

@mavasani mavasani merged commit 113dadc into main Jan 12, 2023
@mavasani mavasani deleted the revert-6364-net7-tests branch January 12, 2023 13:22
@github-actions github-actions bot added this to the vNext milestone Jan 12, 2023
@mavasani
Copy link
Contributor Author

@mavasani Do we want to revert #6409 too?

@jmarolf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants