Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CA2021 for casting interfaces from/to structs #6528

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Mar 12, 2023

Fix another case of #6457 where casting struct <-> interface would always flag.

@hoyosjs hoyosjs requested a review from a team as a code owner March 12, 2023 19:07
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #6528 (7f5e692) into main (253bcd3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6528   +/-   ##
=======================================
  Coverage   96.41%   96.42%           
=======================================
  Files        1372     1372           
  Lines      319875   319898   +23     
  Branches    10275    10275           
=======================================
+ Hits       308422   308453   +31     
+ Misses       8993     8986    -7     
+ Partials     2460     2459    -1     

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n buyaa-n merged commit 5212c6e into dotnet:main Mar 12, 2023
@github-actions github-actions bot added this to the vNext milestone Mar 12, 2023
@hoyosjs hoyosjs deleted the juhoyosa/fix-cast-struct-iface branch March 12, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants