Support generating public resource files #6827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change minimizes the number of cases in code that need to account for switching between public and internal accessibility based on per-file options.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6827 +/- ##
========================================
Coverage 96.36% 96.37%
========================================
Files 1401 1401
Lines 329956 330085 +129
Branches 10837 10842 +5
========================================
+ Hits 317965 318103 +138
+ Misses 9259 9250 -9
Partials 2732 2732 |
mavasani
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue mentioned in a comment: #5521 (comment)
The
Format*methods produced whenEmitFormatMethodsis set to true are not declared public, pending a resolution of #6579.