Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BannedApiAnalyzers: Support banning base types #7052

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

aelij
Copy link
Contributor

@aelij aelij commented Nov 22, 2023

Fixes #6841

Note I've had to change XUnitVerifier to DefaultVerifier due to the following exception:

  Error Message:
   System.MissingMethodException : Method not found: 'Void Xunit.Sdk.EqualException..ctor(System.Object, System.Object)'.
  Stack Trace:
     at Microsoft.CodeAnalysis.Testing.Verifiers.EqualWithMessageException..ctor(Object expected, Object actual, String userMessage)
   at Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier.Equal[T](T expected, T actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Testing.Verifiers.XUnit/XUnitVerifier.cs:line 49

See dotnet/roslyn-sdk#1099 (comment)

@aelij aelij requested a review from a team as a code owner November 22, 2023 14:40
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #7052 (5997981) into main (cc67474) will decrease coverage by 0.01%.
The diff coverage is 84.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7052      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files        1412     1412              
  Lines      336560   336629      +69     
  Branches    11119    11123       +4     
==========================================
+ Hits       324558   324613      +55     
- Misses       9201     9213      +12     
- Partials     2801     2803       +2     

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mavasani mavasani merged commit 6980ee7 into dotnet:main Nov 29, 2023
@aelij aelij deleted the feature/banned-base-types branch November 29, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BannedApiAnalyzer does not prevent inheritance or Implementation
3 participants