-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve implementation of analyzer assembly loader
- Loading branch information
Showing
31 changed files
with
272 additions
and
374 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerAssemblyLoader.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Collections.Immutable; | ||
| using System.Diagnostics; | ||
| using System.IO; | ||
| using System.Reflection; | ||
| using Roslyn.Utilities; | ||
|
|
||
| namespace Microsoft.CodeAnalysis | ||
| { | ||
| internal abstract class AnalyzerAssemblyLoader : IAnalyzerAssemblyLoader | ||
| { | ||
| private readonly object _guard = new object(); | ||
|
|
||
| // lock _guard to read/write | ||
| private readonly Dictionary<string, Assembly> _loadedAssembliesByPath = new Dictionary<string, Assembly>(); | ||
| private readonly Dictionary<AssemblyIdentity, Assembly> _loadedAssembliesByIdentity = new Dictionary<AssemblyIdentity, Assembly>(); | ||
|
|
||
| // maps file name to a full path (lock _guard to read/write): | ||
| private readonly Dictionary<string, List<string>> _knownAssemblyPathsBySimpleName = new Dictionary<string, List<string>>(StringComparer.OrdinalIgnoreCase); | ||
|
|
||
| protected abstract Assembly LoadFromPathImpl(string fullPath); | ||
|
|
||
| #region Public API | ||
|
|
||
| public void AddDependencyLocation(string fullPath) | ||
| { | ||
| CompilerPathUtilities.RequireAbsolutePath(fullPath, nameof(fullPath)); | ||
| string simpleName = PathUtilities.GetFileName(fullPath, includeExtension: false); | ||
|
|
||
| lock (_guard) | ||
| { | ||
| List<string> paths; | ||
| if (!_knownAssemblyPathsBySimpleName.TryGetValue(simpleName, out paths)) | ||
| { | ||
| _knownAssemblyPathsBySimpleName.Add(simpleName, new List<string>() { fullPath }); | ||
| } | ||
| else if (!paths.Contains(fullPath)) | ||
| { | ||
| paths.Add(fullPath); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public Assembly LoadFromPath(string fullPath) | ||
| { | ||
| CompilerPathUtilities.RequireAbsolutePath(fullPath, nameof(fullPath)); | ||
| return LoadFromPathUnchecked(fullPath); | ||
| } | ||
|
|
||
| #endregion | ||
|
|
||
| private Assembly LoadFromPathUnchecked(string fullPath) | ||
| { | ||
| Debug.Assert(PathUtilities.IsAbsolute(fullPath)); | ||
|
|
||
| lock (_guard) | ||
| { | ||
| Assembly existingAssembly; | ||
| if (_loadedAssembliesByPath.TryGetValue(fullPath, out existingAssembly)) | ||
| { | ||
| return existingAssembly; | ||
| } | ||
| } | ||
|
|
||
| Assembly assembly = LoadFromPathImpl(fullPath); | ||
| return AddToCache(assembly, fullPath); | ||
| } | ||
|
|
||
| private Assembly AddToCache(Assembly assembly, string fullPath) | ||
| { | ||
| Debug.Assert(PathUtilities.IsAbsolute(fullPath)); | ||
| Debug.Assert(assembly != null); | ||
|
|
||
| var identity = AssemblyIdentity.FromAssemblyDefinition(assembly); | ||
|
|
||
| lock (_guard) | ||
| { | ||
| // The same assembly may be loaded from two different full paths (e.g. when loaded from GAC, etc.), | ||
| // or another thread might have loaded the assembly after we checked above. | ||
| Assembly existingAssembly; | ||
| if (_loadedAssembliesByIdentity.TryGetValue(identity, out existingAssembly)) | ||
| { | ||
| return existingAssembly; | ||
| } | ||
|
|
||
| _loadedAssembliesByIdentity.Add(identity, assembly); | ||
|
|
||
| // An assembly file might be replaced by another file with a different identity. | ||
| // Last one wins. | ||
| _loadedAssembliesByPath[fullPath] = assembly; | ||
|
|
||
| return assembly; | ||
| } | ||
| } | ||
|
|
||
| public Assembly Load(string displayName) | ||
| { | ||
| AssemblyIdentity requestedIdentity; | ||
| if (!AssemblyIdentity.TryParseDisplayName(displayName, out requestedIdentity)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| ImmutableArray<string> candidatePaths; | ||
| lock (_guard) | ||
| { | ||
| Assembly existingAssembly; | ||
|
|
||
| // First, check if this loader already loaded the requested assembly: | ||
| if (_loadedAssembliesByIdentity.TryGetValue(requestedIdentity, out existingAssembly)) | ||
| { | ||
| return existingAssembly; | ||
| } | ||
|
|
||
| // Second, check if an assembly file of the same simple name was registered with the loader: | ||
| List<string> pathList; | ||
| if (!_knownAssemblyPathsBySimpleName.TryGetValue(requestedIdentity.Name, out pathList)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| Debug.Assert(pathList.Count > 0); | ||
| candidatePaths = pathList.ToImmutableArray(); | ||
| } | ||
|
|
||
| // Multiple assemblies of the same simple name but different identities might have been registered. | ||
| // Load the one that matches the requested identity (if any). | ||
| foreach (var candidatePath in candidatePaths) | ||
| { | ||
| var candidateIdentity = AssemblyIdentityUtils.TryGetAssemblyIdentity(candidatePath); | ||
|
|
||
| if (requestedIdentity.Equals(candidateIdentity)) | ||
| { | ||
| return LoadFromPathUnchecked(candidatePath); | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.