Apply suggestions from code review

dotnet · Mar 22, 2024 · 77f93d3 · 77f93d3
1 parent c0f4f12
commit 77f93d3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs b/src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs
@@ -398,7 +398,9 @@ public MethodSymbol WellKnownMethod(WellKnownMember wm)
         /// <returns>A symbol for the special member.</returns>
         public Symbol SpecialMember(SpecialMember sm)
         {
-            return SpecialMember(sm, isOptional: false)!;
+            var result = SpecialMember(sm, isOptional: false);
+            Debug.Assert(result is not null);
+            return result;
         }
 
         public Symbol? SpecialMember(SpecialMember sm, bool isOptional = false)
@@ -437,7 +439,9 @@ public Symbol SpecialMember(SpecialMember sm)
 
         public MethodSymbol SpecialMethod(SpecialMember sm)
         {
-            return (MethodSymbol)SpecialMember(sm, isOptional: false)!;
+            var result = (MethodSymbol)SpecialMember(sm, isOptional: false);
+            Debug.Assert(result is not null);
+            return result;
         }
 
         public MethodSymbol? SpecialMethod(SpecialMember sm, bool isOptional)

diff --git a/src/Compilers/Core/Portable/ExtendedSpecialType.cs b/src/Compilers/Core/Portable/ExtendedSpecialType.cs
@@ -30,12 +30,6 @@ private ExtendedSpecialType(int value)
         public static explicit operator ExtendedSpecialType(int value) => new ExtendedSpecialType(value);
         public static explicit operator int(ExtendedSpecialType value) => value._value;
 
-        public static bool operator ==(ExtendedSpecialType left, SpecialType right) => left._value == (byte)right;
-        public static bool operator !=(ExtendedSpecialType left, SpecialType right) => !(left == right);
-
-        public static bool operator ==(SpecialType left, ExtendedSpecialType right) => right == left;
-        public static bool operator !=(SpecialType left, ExtendedSpecialType right) => right != left;
-
         public static bool operator ==(ExtendedSpecialType left, ExtendedSpecialType right) => left._value == right._value;
         public static bool operator !=(ExtendedSpecialType left, ExtendedSpecialType right) => !(left == right);