Fix SimpleDiagnostic GetHashCode is more specific than Equals

dotnet · Feb 6, 2015 · 7b57680 · 7b57680
1 parent ef583af
commit 7b57680
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 6 deletions.
diff --git a/src/Compilers/Core/Portable/Diagnostic/Diagnostic_SimpleDiagnostic.cs b/src/Compilers/Core/Portable/Diagnostic/Diagnostic_SimpleDiagnostic.cs
@@ -34,13 +34,18 @@ private SimpleDiagnostic(
                 if ((warningLevel == 0 && severity != DiagnosticSeverity.Error) ||
                     (warningLevel != 0 && severity == DiagnosticSeverity.Error))
                 {
-                    throw new ArgumentException("warningLevel");
+                    throw new ArgumentException(nameof(warningLevel));
+                }
+
+                if(descriptor == null)
+                {
+                    throw new ArgumentNullException(nameof(descriptor));
                 }
 
                 _descriptor = descriptor;
                 _severity = severity;
                 _warningLevel = warningLevel;
-                _location = location;
+                _location = location ?? Location.None;
                 _additionalLocations = additionalLocations == null ? SpecializedCollections.EmptyReadOnlyList<Location>() : additionalLocations.ToImmutableArray();
                 _messageArgs = messageArgs ?? SpecializedCollections.EmptyArray<object>();
             }
@@ -131,10 +136,9 @@ public override bool Equals(object obj)
             public override int GetHashCode()
             {
                 return Hash.Combine(_descriptor,
-                        Hash.Combine(_messageArgs.GetHashCode(),
-                         Hash.Combine(_location.GetHashCode(),
-                          Hash.Combine(_severity.GetHashCode(), _warningLevel)
-                        )));
+                    Hash.CombineValues(_messageArgs,
+                    Hash.Combine(_warningLevel,
+                    Hash.Combine(_location, (int)_severity))));
             }
 
             internal override Diagnostic WithLocation(Location location)

diff --git a/src/Compilers/Core/Portable/InternalUtilities/Hash.cs b/src/Compilers/Core/Portable/InternalUtilities/Hash.cs
@@ -66,6 +66,30 @@ internal static int CombineValues<T>(IEnumerable<T> values, int maxItemsToHash =
             return hashCode;
         }
 
+        internal static int CombineValues<T>(T[] values, int maxItemsToHash = int.MaxValue)
+        {
+            if (values == null)
+            {
+                return 0;
+            }
+
+            var maxSize = Math.Min(maxItemsToHash, values.Length);
+            var hashCode = 0;
+
+            for (int i = 0; i < maxSize; i++)
+            {
+                T value = values[i];
+
+                // Should end up with a constrained virtual call to object.GetHashCode (i.e. avoid boxing where possible).
+                if (value != null)
+                {
+                    hashCode = Hash.Combine(value.GetHashCode(), hashCode);
+                }
+            }
+
+            return hashCode;
+        }
+
         internal static int CombineValues<T>(ImmutableArray<T> values, int maxItemsToHash = int.MaxValue)
         {
             if (values.IsDefaultOrEmpty)