Resolve PROTOTYPE comments in param null checking (#58324)

* Resolve PROTOTYPE comments in param null checking Filed the following issues: - #58323 - #58322 - #58320 * Remove unnecessary issue link
dotnet · Dec 15, 2021 · 897223b · 897223b
1 parent 81e44e1
commit 897223b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/Compilers/CSharp/Test/Emit2/CodeGen/CodeGenNullCheckedParameterTests.cs b/src/Compilers/CSharp/Test/Emit2/CodeGen/CodeGenNullCheckedParameterTests.cs
@@ -314,10 +314,9 @@ .locals init (int V_0)
 }", sequencePoints: "Box.op_Addition");
         }
 
-        [Fact(Skip = "PROTOTYPE")]
+        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/58322")]
         public void TestNullCheckedArgListImplementation()
         {
-            // PROTOTYPE : Will address later - issues with post-fix & binding?
             var source = @"
 class C
 {

diff --git a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_NullCheckedParameters.cs b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_NullCheckedParameters.cs
@@ -241,7 +241,7 @@ public class Box
         [Fact]
         public void TestIOp_NullCheckedIndexedProperty()
         {
-            // PROTOTYPE 
+            // https://github.com/dotnet/roslyn/issues/58320
             var source = @"
 public class C
 {
@@ -2463,7 +2463,7 @@ public void Method(int? x!!) { }
         [Fact]
         public void TestNoNullChecksInBlockOperation()
         {
-            // PROTOTYPE - Nullchecks currently included when only BlockSyntax is bound. Falls into VisitMethodBody instead of VisitBlock.
+            // https://github.com/dotnet/roslyn/issues/58320
             var source = @"
 public class C
 {

diff --git a/src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs b/src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
@@ -7935,7 +7935,6 @@ class Box
         [Fact]
         public void TestAnonymousDelegateNullChecking()
         {
-            // PROTOTYPE : During semantics, make sure this causes an error
             UsingTree(@"
 delegate void Del(int x!!);
 Del d = delegate(int k!!) { /* ... */ };", options: TestOptions.RegularPreview);