Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion on out in local function impedes with typing #22253

Closed
jcouv opened this issue Sep 21, 2017 · 3 comments
Closed

Completion on out in local function impedes with typing #22253

jcouv opened this issue Sep 21, 2017 · 3 comments
Assignees
@chborl
Labels
Area-IDE Bug
Milestone
15.5

Comments

@jcouv
Copy link
Member

jcouv commented Sep 21, 2017 •
edited
Loading

I tried to add an out parameter to a local function and Intellisense forced a completion of a type name instead of out.

image

FYI @agocke @Pilchie for triage
@jcouv jcouv added the Area-IDE label Sep 21, 2017
@dpoeschl dpoeschl added the Bug label Sep 21, 2017
@dpoeschl
Copy link
Contributor

The OutKeywordRecommender doesn't seem to be kicking in here. Can you take a look?

@dpoeschl dpoeschl added this to the 15.5 milestone Sep 21, 2017
@dpoeschl
Copy link
Contributor

dpoeschl commented Sep 25, 2017 •
edited
Loading

Smaller standalone repro:

using System;

class C
{
    void M()
    {
        void F($$)
    }
}

chborl pushed a commit to chborl/roslyn that referenced this issue Sep 27, 2017
Fix ref and out keyword completion to appear in local functions
fae19bd 
Fixes dotnet#22253
@chborl chborl mentioned this issue Sep 27, 2017
Closed
chborl pushed a commit to chborl/roslyn that referenced this issue Sep 27, 2017
Added tests for out and ref completion in local function
8e22a51 
Tests in response to issue dotnet#22253
@chborl chborl mentioned this issue Sep 28, 2017
Merged
@chborl
Copy link
Contributor

chborl commented Sep 28, 2017

Issue fixed by #17447 which was merged into master with #22050.
Tests added in #22388

@chborl chborl closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chborl chborl

Labels
Area-IDE Bug
Projects
None yet
Milestone
15.5
Development

Successfully merging a pull request may close this issue.

Fix ref and out keyword completion to appear in local functions chborl/roslyn
3 participants
@dpoeschl @jcouv @chborl